ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt <mithm...@gmail.com>
Subject Re: Review Request 43511: Refactor HAWQ common.py after moving config substitution to UI
Date Fri, 12 Feb 2016 03:22:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43511/#review118979
-----------------------------------------------------------


Ship it!




Ship It!


ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line
70)
<https://reviews.apache.org/r/43511/#comment180283>

    The comment about 'append related parameters' is obsolete.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line
75)
<https://reviews.apache.org/r/43511/#comment180282>

    The comment about 'append related parameters' is obsolete.


- Matt


On Feb. 11, 2016, 6:21 p.m., Lav Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43511/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 6:21 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary,
Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15019
>     https://issues.apache.org/jira/browse/AMBARI-15019
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Use partial function for XmlConfig. Functions __update_yarn_client, __update_hawq_site,
__update_hdfs_client may no longer be required.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
23342f5 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
add3c63 
> 
> Diff: https://reviews.apache.org/r/43511/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message