ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yusaku Sako <yus...@hortonworks.com>
Subject Re: Review Request 42489: TimelineServer configuration is missing in yarn-env.xml
Date Fri, 12 Feb 2016 03:08:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42489/#review118976
-----------------------------------------------------------


Ship it!




Ship It!

- Yusaku Sako


On Jan. 20, 2016, 11:37 p.m., Akira Ajisaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42489/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 11:37 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14715
>     https://issues.apache.org/jira/browse/AMBARI-14715
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In yarn-env.xml, HISTORYSERVER should be TIMELINESERVER.
> ```
>       # Specify the max Heapsize for the HistoryManager using a numerical value
>       # in the scale of MB. For example, to specify an jvm option of -Xmx1000m, set
>       # the value to 1024.
>       # This value will be overridden by an Xmx setting specified in either YARN_OPTS
>       # and/or YARN_HISTORYSERVER_OPTS.
>       # If not specified, the default value will be picked from either YARN_HEAPMAX
>       # or JAVA_HEAP_MAX with YARN_HEAPMAX as the preferred option of the two.
>       export YARN_HISTORYSERVER_HEAPSIZE={{apptimelineserver_heapsize}}
> ```
> I'm thinking this issue is a regression in HDP 2.3.X.
> In HDP 2.1/2.2, yarn-env.xml is as follows:
> ```
> # Specify the max Heapsize for the timeline server using a numerical value
> # in the scale of MB. For example, to specify an jvm option of -Xmx1000m, set
> # the value to 1024.
> # This value will be overridden by an Xmx setting specified in either YARN_OPTS
> # and/or YARN_TIMELINESERVER_OPTS.
> # If not specified, the default value will be picked from either YARN_HEAPMAX
> # or JAVA_HEAP_MAX with YARN_HEAPMAX as the preferred option of the two.
> export YARN_TIMELINESERVER_HEAPSIZE={{apptimelineserver_heapsize}}
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml
e802b24 
> 
> Diff: https://reviews.apache.org/r/42489/diff/
> 
> 
> Testing
> -------
> 
> Jenkins log:
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12783037/AMBARI-14715.001.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 release audit. The applied patch does not increase the total number of release audit
warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> 
> Thanks,
> 
> Akira Ajisaka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message