ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Nettleton <rnettle...@hortonworks.com>
Subject Re: Review Request 43482: Ldap Sync: Concurrent modification exception
Date Thu, 11 Feb 2016 14:08:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43482/#review118868
-----------------------------------------------------------


Fix it, then Ship it!




The patch looks fine, but I think this needs more investigation, to determine why duplicate
groups are included in the DB. 

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
(line 298)
<https://reviews.apache.org/r/43482/#comment180181>

    Could we get some more background on the root of the original exception? 
    
    The change in this patch seems straightforward, in that it looks like there must be duplicate
entries for a given group in the "internalGroupsMap". 
    
    Is having duplicate groups with the same name a valid condition?  
    
    From a quick glance, it looks like this class obtains the list of internal groups from:
    
    org.apache.ambari.server.security.ldap.AmbariLdapDataPopulator#getInternalGroups
    
    which appears to query the DB in order to obtain this information. 
    
    Could this problem be caused by an invalid database state?  
    
    I'm not against this change as it is, but I do think we should know more about why the
DB includes duplicate groups, and if that is a valid condition. 
    
    Thanks.


- Robert Nettleton


On Feb. 11, 2016, 1:39 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43482/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 1:39 p.m.)
> 
> 
> Review request for Ambari, Robert Levas and Robert Nettleton.
> 
> 
> Bugs: AMBARI-15013
>     https://issues.apache.org/jira/browse/AMBARI-15013
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Concurrent modification exception can occour during ldap sync. (not always)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java
21492cf 
>   ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
be92871 
> 
> Diff: https://reviews.apache.org/r/43482/diff/
> 
> 
> Testing
> -------
> 
> Unit testiong is in progress
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message