ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Levas <rle...@hortonworks.com>
Subject Re: Review Request 43428: Provide explicit ordering for roles
Date Thu, 11 Feb 2016 14:03:50 GMT


> On Feb. 11, 2016, 8:48 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 1062-1075
> > <https://reviews.apache.org/r/43428/diff/2/?file=1239768#file1239768line1062>
> >
> >     Any reason these are not in the order according to the sort? I know it makes
no difference, but visually it would be easier to see if there were errors.

The are left in order of their `permission_id`, which is ordered that way for historical reasons
- meaning there are several places in the code that assume the Ambari adminstrator has permission_id
1, etc...


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43428/#review118864
-----------------------------------------------------------


On Feb. 10, 2016, 2:23 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43428/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-14980
>     https://issues.apache.org/jira/browse/AMBARI-14980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Since it may be desired to order roles in ways other than alphabetically, each role should
have an explicit numerical order that may be used by UI's. 
> 
> Roles should be explicitly ordered by the amount of access privileges they have. 
> 
> 
> Role Name             | Explicit Order Value 
> ----------------------|----------------------
> Ambari Administrator  | 1
> Cluster Administrator | 2
> Cluster Operator      | 3
> Service Administrator | 4
> Service Operator      | 5
> Cluster User          | 6
> View User             | 7
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java
640123e 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
a692730 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
3414388 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0fdfd2b 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 11e43c2 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8d4ba28 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c762ac4 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 81b41fe 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql f8c9b8d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 324c24d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
7658c0f 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
d1d68f2 
> 
> Diff: https://reviews.apache.org/r/43428/diff/
> 
> 
> Testing
> -------
> 
> Manualy tested a new install and an upgrade
> 
> # Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:03:22.906s
> [INFO] Finished at: Wed Feb 10 14:03:26 EST 2016
> [INFO] Final Memory: 68M/1507M
> [INFO] ------------------------------------------------------------------------
> 
> # Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message