ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sid Wagle <swa...@hortonworks.com>
Subject Re: Review Request 43278: AMBARI-14945: Some options have not been applied on Ambari Metrics Collector
Date Wed, 10 Feb 2016 22:15:45 GMT


> On Feb. 10, 2016, 7:01 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector,
line 264
> > <https://reviews.apache.org/r/43278/diff/1/?file=1236943#file1236943line264>
> >
> >     Not sure what happens because of doulbe quotes? The double-quotes is still a
valid shell expression. Could you please paste the outcome of the "ps aux | grep proc_timelineserver
| grep ams" to indicate the problem.

Defnition from ams-env.sh:

# AMS Collector options
export AMS_COLLECTOR_OPTS="-Djava.library.path=/usr/lib/ams-hbase/lib/hadoop-native"
{% if security_enabled %}
export AMS_COLLECTOR_OPTS="$AMS_COLLECTOR_OPTS -Djava.security.auth.login.config={{ams_collector_jaas_config_file}}"
{% endif %}


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43278/#review118709
-----------------------------------------------------------


On Feb. 10, 2016, 11:34 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43278/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 11:34 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, jun aoki, Robert Levas, Sid Wagle,
and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14945
>     https://issues.apache.org/jira/browse/AMBARI-14945
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It looks like `AMS_COLLECTOR_GC_OPTS` ( which is defined in `ams-env.xml` ) is interpreted
as `java.library.path`.
> 
> This is caused by an initialization script `/usr/sbin/ambari-metrics-collector`.
> 
> `AMS_COLLECTOR_OPTS` should not be double-quoted.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector bf2fc47

> 
> Diff: https://reviews.apache.org/r/43278/diff/
> 
> 
> Testing
> -------
> 
> Manually testing done
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message