ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sid Wagle <swa...@hortonworks.com>
Subject Re: Review Request 43337: AMBARI-14962 Auto configure AMS UI to use AMS Datasource
Date Wed, 10 Feb 2016 19:39:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43337/#review118716
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 10, 2016, 7:31 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43337/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 7:31 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14962
>     https://issues.apache.org/jira/browse/AMBARI-14962
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> TODO
> Invoke Grafana's create datasource REST call to configure the datasource as part of AMS
UI lifecycle commands (say "Start").
> 
> IMPLEMENTATION LOGIC
> 
> . During Grafana START
> . Check if AMBARI_METRICS datasource already exists in Grafana.
> . If datasource EXISTS
>   . Check Collector Host is valid.
>   . If not valid, delete obselete datasource entry from Grafana.
>   . If Collector host valid, skip_creating_datasource = True. 
> . If skip_creating_datasource != True
>   . Create datasource with name = AMBARI_METRICS and URL as the current collector URL.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
c4a91e1 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2
3edc6fb 
> 
> Diff: https://reviews.apache.org/r/43337/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> Added Unit tests
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message