ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nate Cole <nc...@hortonworks.com>
Subject Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades
Date Wed, 10 Feb 2016 15:53:55 GMT


> On Feb. 10, 2016, 10:34 a.m., Jonathan Hurley wrote:
> > Looking again at this review, I really dislike that we have to include all of the
patch*.xml files. However, I understand why we have them. If we ever had to change something
structually, it would be a mess to try to annotate the upgrade packs. 
> > 
> > I just don't know which way to go on this.

Ok, consensus is that we change to annotate existing upgrade packs.  Bring on the pain!


> On Feb. 10, 2016, 10:34 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java, line
236
> > <https://reviews.apache.org/r/43377/diff/1/?file=1238815#file1238815line236>
> >
> >     What is RepositoryType.SERVICE? I thought there were only going to be full and
partial?

RepositoryType.SERVICE is not the same as UpgradeScope.PARTIAL.  Both RepositoryType.PATCH
and RepositoryType.SERVICE imply that you are only PARTIALly upgrading your cluster.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43377/#review118663
-----------------------------------------------------------


On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43377/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 6:01 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14978
>     https://issues.apache.org/jira/browse/AMBARI-14978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Created separate upgrade packs for patches.  The necessitated a new enum UpgradeScope
to indicate that the upgrade was for partial cluster upgrades (which will help when doing
Component (Service) Upgrades).
> 
> Also added a fix for orchestration of ClusterGroupings that target specific services
that are not getting upgraded.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 0d9176d

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b860731

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
5e21da5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java b15157e

>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43377/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> 
> Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:52.026s
> [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016
> [INFO] Final Memory: 33M/677M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message