ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun aoki <jun.aoki....@gmail.com>
Subject Re: Review Request 43370: AMS cannot be installed on trunk
Date Tue, 09 Feb 2016 19:06:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43370/#review118434
-----------------------------------------------------------




ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
(line 45)
<https://reviews.apache.org/r/43370/#comment179646>

    I wonder if ambari-common is right place for the conditional logic. We are trying to decouple
between service definitions and core part, and this implementation seems to bring a service
(grafana) specific logic back in core.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml (line 99)
<https://reviews.apache.org/r/43370/#comment179651>

    Could this be more expandable if it is a full path to a py file + a method name ? the
conditional logic is specific to grafana and we can have it in grafana's service defintion
(or anywhere you want)
    
    Here is my not-so-sophisticated example
    ```
    <condition>common-servies/AMBARI_METRICS/0.1.0/package/scripts/condition.py#should_install_ams_grafana
    ```


- jun aoki


On Feb. 9, 2016, 6:57 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43370/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 6:57 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-14964
>     https://issues.apache.org/jira/browse/AMBARI-14964
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS cannot be installed on trunk
> Creating this review on behalf of  Aravindan Vijayan
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
0fb0fe4 
>   ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/AMBARI_METRICS/metainfo.xml
be99b83 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
c3dbc6b 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
ddefed7 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py
d96309c 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
921bed7 
> 
> Diff: https://reviews.apache.org/r/43370/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jun aoki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message