ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sreenath Somarajapuram <ssomarajapu...@hortonworks.com>
Subject Re: Review Request 43089: View: Capacity Scheduler View: Cannot delete 'root.default' queue when it should be
Date Tue, 09 Feb 2016 09:13:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43089/#review118367
-----------------------------------------------------------




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDelete.js (line
42)
<https://reviews.apache.org/r/43089/#comment179607>

    Probably
    if (this.get("param.id") === 'root.default')
    might be better.



contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less (line 264)
<https://reviews.apache.org/r/43089/#comment179606>

    Please keep a check on the intentation.


- Sreenath Somarajapuram


On Feb. 2, 2016, 12:17 p.m., Akhil PB wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43089/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 12:17 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-14873
>     https://issues.apache.org/jira/browse/AMBARI-14873
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enabled deletion for default queue in capacity scheduler view.
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDelete.js
5ada051 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473

>   contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
c0acf4f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1

> 
> Diff: https://reviews.apache.org/r/43089/diff/
> 
> 
> Testing
> -------
> 
> Done manual unit testing in ambari operator/admin mode.
> 
> 
> Thanks,
> 
> Akhil PB
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message