ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 43266: Config consistency checker
Date Mon, 08 Feb 2016 18:47:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43266/#review118264
-----------------------------------------------------------



Nicely done.


ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line
138)
<https://reviews.apache.org/r/43266/#comment179489>

    Small correction to the name, should be "...MoreThanOnce"



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line
138)
<https://reviews.apache.org/r/43266/#comment179490>

    Small correction to the name, should be "...MoreThanOnce"



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line
139)
<https://reviews.apache.org/r/43266/#comment179492>

    Does this query work on all DB types? I tried it on postgres and it was ok.



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line
233)
<https://reviews.apache.org/r/43266/#comment179495>

    We can actually make a stronger assertion here>
    Each tuple is uniquely identified by <service_name, component_name, host_id>
    
    We can ensure that this number is also equal,
    
    select count(*) FROM hostcomponentstate hcs JOIN hostcomponentdesiredstate hcds ON hcs.service_name
= hcds.service_name AND hcs.component_name = hcds.component_name AND hcs.host_id = hcds.host_id;



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line
256)
<https://reviews.apache.org/r/43266/#comment179497>

    Nice!



ambari-server/src/main/python/ambari-server.py (line 529)
<https://reviews.apache.org/r/43266/#comment179498>

    Can we always call check-database on startup?
    Even if it fails, Ambari Server should be allowed to start.


- Alejandro Fernandez


On Feb. 6, 2016, 6:43 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43266/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-14948
>     https://issues.apache.org/jira/browse/AMBARI-14948
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Command line utility to find inconsistencies in configs
> Services without configs
> Configs without services
> relationship between clusterconfig, serviceconfigmapping, and clusterconfigmapping
> Do outter joins and find missing configs
> At least one should be selected for config type, compare known config types vs expected
in the stack, versions are incremental
> 
> 
> Diffs
> -----
> 
>   ambari-server/sbin/ambari-server 47e2926 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java
PRE-CREATION 
>   ambari-server/src/main/python/ambari-server.py 8be79a5 
>   ambari-server/src/main/python/ambari_server/checkDatabase.py PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/setupActions.py 686ac9a 
> 
> Diff: https://reviews.apache.org/r/43266/diff/
> 
> 
> Testing
> -------
> 
> Will add tests later
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message