ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaimin Jetly <jai...@hortonworks.com>
Subject Re: Review Request 43055: AMBARI-14403: Improve Quicklink logic to remove any unnecessary legacy code
Date Mon, 08 Feb 2016 06:50:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43055/#review118204
-----------------------------------------------------------


Ship it!




Ship It!

- Jaimin Jetly


On Feb. 5, 2016, 2:40 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43055/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 2:40 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Richard Zang, Srimanth Gunturi,
and Xi Wang.
> 
> 
> Bugs: AMBARI-14403
>     https://issues.apache.org/jira/browse/AMBARI-14403
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During the review process of JIRA AMBARI-11268, it was discussed that the quicklink required
UI code may use some refactoring to remove unnecessary legacy code.
> 
> use this jira for the work.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java a0890f1

>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json
bbea282 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
dd17275 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 194f79e

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml a5d6862

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml 8b24091

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
e7c23a4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml 7a1c715

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
7e2ba25 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/SPARK/quicklinks/quicklinks.json
c3e51e6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
21c5e54 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
dd67ec0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
b52af55 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
9fb97d0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
e7c23a4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/quicklinks/quicklinks.json
74ea153 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/quicklinks/quicklinks.json
c3e51e6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
993267d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
3cf4c7f 
>   ambari-server/src/test/resources/child_quicklinks_to_merge.json 819c400 
>   ambari-server/src/test/resources/child_quicklinks_to_override.json b042f98 
>   ambari-server/src/test/resources/parent_quicklinks.json 3cf4c7f 
>   ambari-web/app/assets/data/configurations/quicklinks.json 505a619 
>   ambari-web/app/views/common/quick_view_link_view.js c2f7dcc 
> 
> Diff: https://reviews.apache.org/r/43055/diff/
> 
> 
> Testing
> -------
> 
> unit test
> 
> manually patch a cluster with UI changes and load quick links to make sure I can open
external links.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message