ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nate Cole <nc...@hortonworks.com>
Subject Re: Review Request 43255: Some user-specified auth-to-local rules fail to render when auto generating auth-to-local rules
Date Fri, 05 Feb 2016 17:16:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43255/#review118033
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java (lines
118 - 125)
<https://reviews.apache.org/r/43255/#comment179312>

    Cloneable/clone()?  Won't hold up review for it :)


- Nate Cole


On Feb. 5, 2016, 11:38 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43255/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 11:38 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-14938
>     https://issues.apache.org/jira/browse/AMBARI-14938
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When processing the user-specified auth-to-local rules while automatically generating
auth-to-local rule sets using `org.apache.ambari.server.controller.AuthToLocalBuilder`, some
rules fail to render.
> 
> This occurs when escape characters are used in the replacement pattern or replacement
string of the rule, where a role looks like:
> 
> ```
> RULE: [n:string](regexp)s/pattern/replacement/[g]
> ```
> 
> To fix this issue, the regular expression used to parse the rules need to be augmented
to allow for those characters.
> 
> NOTE: Also did some cleanup of `org.apache.ambari.server.controller.AuthToLocalBuilder`.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
a8fc487 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
556bed8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AuthToLocalBuilderTest.java
122e632 
> 
> Diff: https://reviews.apache.org/r/43255/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Local test results: PASSED
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message