ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexandr Antonenko <hiv...@gmail.com>
Subject Re: Review Request 43189: AMBARI-14871: Better messages when Ambari web UI can't resolve hosts to build quicklinks
Date Fri, 05 Feb 2016 16:36:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43189/#review118026
-----------------------------------------------------------




ambari-web/app/views/common/quick_view_link_view.js (line 442)
<https://reviews.apache.org/r/43189/#comment179308>

    Why are you making a compare with null ? I do not see any posible way oozieHostsArray
can get null value


- Alexandr Antonenko


On Feb. 5, 2016, 2:39 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43189/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-14871
>     https://issues.apache.org/jira/browse/AMBARI-14871
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It currently says "Hostname is undefined". This JIRA is to update the logic a little
bit in an attempt to display better error messages.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js 8861b2a 
>   ambari-web/app/templates/main/service/item.hbs f61695e 
>   ambari-web/app/views/common/quick_view_link_view.js c2f7dcc 
>   ambari-web/test/views/common/quick_link_view_test.js 93a235c 
> 
> Diff: https://reviews.apache.org/r/43189/diff/
> 
> 
> Testing
> -------
> 
> unit test
> 
> manually patch a cluster and test the error message when oozie server is stopped.
> 
> 
> Thanks,
> 
> Di Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message