ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmytro Sen <d...@hortonworks.com>
Subject Re: Review Request 43125: AMBARI-14892 : Add Grafana as a component to AMS
Date Fri, 05 Feb 2016 11:50:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/#review118008
-----------------------------------------------------------


Ship it!




Lets commit it as is. It'll be updated multiple times in other AMS grafana jiras.

- Dmytro Sen


On Фев. 4, 2016, 11:54 п.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43125/
> -----------------------------------------------------------
> 
> (Updated Фев. 4, 2016, 11:54 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14892
>     https://issues.apache.org/jira/browse/AMBARI-14892
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a MASTER component called Grafana to AMS service.
> 
> Include install and start/stop/status scripts for the grafana server.
> 
> Config Management for Ambari Metrics - Grafana also part of this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 1de5401 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
5067454 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
8cbc56b 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
48469df 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
8fdf4ba 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
cf498ec 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
a1d6a1d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
a1de919 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
59466ad 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
d446baa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json a480e2a 
>   ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py PRE-CREATION

>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json f421aec 
> 
> Diff: https://reviews.apache.org/r/43125/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done by installing ambari-metrics-grafana rpm on a host and testing the
patch.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message