ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitro Lisnichenko <dlysniche...@hortonworks.com>
Subject Re: Review Request 43248: Tweaks to reduce build time
Date Fri, 05 Feb 2016 09:01:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43248/#review117994
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 5, 2016, 10:59 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43248/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 10:59 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14936
>     https://issues.apache.org/jira/browse/AMBARI-14936
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1\. Don't build common-services and stacks folder into ambari-server.jar. This
> reduces jar size from 20Mb to 7Mb. And also reduces its buildtime.  
> 2\. -DassemblyPhase=none option to skip building tarballs. Is useful when
> building simply a jar is needed.  
> 3\. -Dnodemodules.dir option to not redownload node_modules folder in ambari-
> web. This reduces ambari-web time from ~1.1 min. to ~15s. (unless it's a first
> build and node_modules is not there). However this may rearly result in npm
> cache issues, which is simply solved by 'rm -rf ambari-web/node_modules'
> 
> 
> Diffs
> -----
> 
>   ambari-agent/pom.xml 7531650 
>   ambari-server/pom.xml 6fb090a 
>   ambari-server/src/main/assemblies/server.xml 17d6bdb 
>   ambari-web/pom.xml 761a3f0 
>   pom.xml 57c6de7 
> 
> Diff: https://reviews.apache.org/r/43248/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message