ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 43123: RU/EU should only delete configs on downgrade if source stack matches stack whose status is CURRENT
Date Wed, 03 Feb 2016 00:25:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43123/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 12:25 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole,
and Swapan Shridhar.


Bugs: AMBARI-14891
    https://issues.apache.org/jira/browse/AMBARI-14891


Repository: ambari


Description
-------

Saw a case with a customer in which they did the following.

* Ambari 2.1.2
* Rolling Upgrade from HDP 2.2 to 2.3.0.0 and skipped the Finalize step, so Ambari never called
"Save DB State". Hence, the current stack version was still 2.2. They then modified the host_version
and cluster_version records in the DB to mark HDP 2.3 as CURRENT.
* Forgot to call ambari-server set-current-version
* Registered and installed bits for HDP 2.3.4.0 and began another RU. After running into an
issue, they decided to downgrade, which then completely removed the configs for the target
stack (which is HDP 2.3!)

In order to prevent deleting configs in cases where the user has modified the database, add
stronger validation to FinalizeUpgradeAction so that we check that the request's source target
stack equals the stack of the repo marked as CURRENT. In this case, they were 2.2 and 2.3,
respectively.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
9331ef0 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
b6bc82e 

Diff: https://reviews.apache.org/r/43123/diff/


Testing
-------

Ran unit tests in UpgradeActionTest.java and verified on a live cluster


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message