ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nate Cole <nc...@hortonworks.com>
Subject Re: Review Request 43054: Use entities for parent/child repository versions
Date Mon, 01 Feb 2016 20:47:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43054/
-----------------------------------------------------------

(Updated Feb. 1, 2016, 3:47 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Changes
-------

Update for comments


Bugs: AMBARI-14867
    https://issues.apache.org/jira/browse/AMBARI-14867


Repository: ambari


Description
-------

The UI wants to show Repo Versions in a hierarchical fashion with patches.

The API doesn't like subresources that are the same type.  Instead of rebuilding how the API
works, this patch provides a has_children and parent_id attributes on the object.  This will
allow the UI to efficiently determine whether a repo is "expandable" without bringing back
huge amounts of data.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d1453a0

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
873733d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
4b0d3cc 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
fa2f905 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql a43211c 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1941331 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 75d2a4b 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1a6c9c6 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql efaa7a9 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 267a1f0 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 828a3a3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
f3cf954 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
PRE-CREATION 
  ambari-server/src/test/resources/version_definition_resource_provider.xml 735f91d 

Diff: https://reviews.apache.org/r/43054/diff/


Testing
-------

Manual.  Automated results pending.


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message