Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Tue, 26 Jan 2016 21:09:39 +0000 (UTC)
From: "Keta Patel (JIRA)" <jira@apache.org>
To: dev@ambari.apache.org
Message-ID: <JIRA.12933171.1453410351000.217226.1453842579879@Atlassian.JIRA>
In-Reply-To: <JIRA.12933171.1453410351000@Atlassian.JIRA>
References: <JIRA.12933171.1453410351000@Atlassian.JIRA>
 <JIRA.12933171.1453410351023@arcas>
Subject: [jira] [Commented] (AMBARI-14766) Selecting ALL groups does not
 work under Manage Alert Notifications
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AMBARI-14766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118032#comment-15118032 ] 

Keta Patel commented on AMBARI-14766:
-------------------------------------

[~onechiporenko], this is in reference to the Jira AMBARI-8631 you had fixed for Manage Alert Notification.
In your fix you had mentioned that if "ALL" radio button for Groups is selected, then we are not passing the "groups" property in the REST call.
But if "CUSTOM" option is selected then "groups" property is passed. 
1. Could you please help me understand the purpose of doing this? 
2. I was looking into the server code and the Alerts basically depend on the "alert_group_target" table to send notifications. But in this case, since we are not passing the groups for ALL, the "alert_group_target" table is not updated and we don't get notifications for all groups. Please correct me if I am wrong in my understanding.
3. Will fixing this issue by passing "groups" for ALL be a correct way of going about?

I have added a patch with proposed fix for your reference.

> Selecting ALL groups does not work under Manage Alert Notifications
> -------------------------------------------------------------------
>
>                 Key: AMBARI-14766
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14766
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server, ambari-web
>    Affects Versions: trunk
>            Reporter: Keta Patel
>            Assignee: Keta Patel
>            Priority: Minor
>         Attachments: AMBARI-14766.patch
>
>
> Selecting "ALL" groups does not work under Manage Alert Notifications.
> Reproduction Steps:-
> 1. Go to Alerts Tab in Ambari GUI
> 2. Actions --> Manage Notifications
> 3. Create New Alert Notification (Click the custom radio button for groups and select couple of options eg HDFS, PIG)
> 4. Save it.
> 5. Edit the newly created Alert notification by clicking on the All radio button. Everything gets selected.
> 6. Save it
> Expected results:
> On Saving the Alert notification, the dialog box "Manage Alert Notification"  should show Groups as ALL ( or Show all the values eg HDFS, PIG, MR2). Basically all the values should be selected.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)