Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BCDC11898B for ; Fri, 22 Jan 2016 15:46:40 +0000 (UTC) Received: (qmail 62216 invoked by uid 500); 22 Jan 2016 15:46:40 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 62175 invoked by uid 500); 22 Jan 2016 15:46:40 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 61839 invoked by uid 99); 22 Jan 2016 15:46:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 15:46:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1D7442C1F6C for ; Fri, 22 Jan 2016 15:46:40 +0000 (UTC) Date: Fri, 22 Jan 2016 15:46:40 +0000 (UTC) From: "Hudson (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-14574) multiple clicks on "Next" button causes skipping of steps while installing a cluster MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112560#comment-15112560 ] Hudson commented on AMBARI-14574: --------------------------------- SUCCESS: Integrated in Ambari-trunk-Commit #4212 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4212/]) AMBARI-14574. multiple clicks on "Next" button causes skipping of steps (hiveww: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=880506c7027c80c1fd7c8e51535980d87b0f04fd]) * ambari-web/app/controllers/wizard/step3_controller.js * ambari-web/app/controllers/wizard/step0_controller.js * ambari-web/app/views/wizard/step7_view.js * ambari-web/test/controllers/wizard/step4_test.js * ambari-web/app/views/wizard/step9_view.js * ambari-web/app/mixins/wizard/assign_master_components.js * ambari-web/app/views/wizard/step10_view.js * ambari-web/app/views/wizard/step3_view.js * ambari-web/app/controllers/wizard.js * ambari-web/app/views/wizard/step4_view.js * ambari-web/test/controllers/wizard/step5_test.js * ambari-web/app/views/wizard/step8_view.js * ambari-web/app/routes/installer.js * ambari-web/app/controllers/wizard/step4_controller.js * ambari-web/app/controllers/wizard/step7_controller.js * ambari-web/test/controllers/wizard/step7_test.js * ambari-web/app/router.js * ambari-web/test/views/wizard/step4_view_test.js * ambari-web/test/views/wizard/step7_view_test.js * ambari-web/test/controllers/wizard/step3_test.js * ambari-web/test/controllers/wizard/step0_test.js Revert "AMBARI-14574. multiple clicks on "Next" button causes skipping (hiveww: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=e9b167e25e3476b538b829c707f5ae04c4f819b7]) * ambari-web/app/controllers/wizard/step4_controller.js * ambari-web/app/views/wizard/step7_view.js * ambari-web/app/views/wizard/step3_view.js * ambari-web/app/views/wizard/step10_view.js * ambari-web/app/controllers/wizard/step3_controller.js * ambari-web/app/views/wizard/step8_view.js * ambari-web/app/views/wizard/step4_view.js * ambari-web/test/controllers/wizard/step3_test.js * ambari-web/test/views/wizard/step4_view_test.js * ambari-web/app/controllers/wizard/step7_controller.js * ambari-web/app/router.js * ambari-web/test/views/wizard/step7_view_test.js * ambari-web/test/controllers/wizard/step0_test.js * ambari-web/app/controllers/wizard.js * ambari-web/app/controllers/wizard/step0_controller.js * ambari-web/app/mixins/wizard/assign_master_components.js * ambari-web/app/routes/installer.js * ambari-web/app/views/wizard/step9_view.js * ambari-web/test/controllers/wizard/step7_test.js * ambari-web/test/controllers/wizard/step5_test.js * ambari-web/test/controllers/wizard/step4_test.js > multiple clicks on "Next" button causes skipping of steps while installing a cluster > ------------------------------------------------------------------------------------ > > Key: AMBARI-14574 > URL: https://issues.apache.org/jira/browse/AMBARI-14574 > Project: Ambari > Issue Type: Bug > Components: ambari-web > Affects Versions: 2.1.1 > Reporter: Keta Patel > Assignee: Keta Patel > Attachments: AMBARI-14574.patch, AMBARI-14574_Jan19_only_nextBtnClickInProgress.patch, AMBARI-14574_Jan19_with_transitionInProgress.patch, AMBARI-14574_Jan20_manual_testing.patch, AMBARI-14574_Jan20_with_fix.patch, attempt_1_controller.tiff, attempt_1_installer.tiff, attempt_2_controller.tiff, attempt_2_installer.tiff, attempt_3_adding_check_for_step1.tiff, attempt_3_removing_check_from_step3.tiff > > > On installation wizard, multiple clicks on the "Next" button can cause skipping of steps. The timing of the 2nd click decides if that click will be processed again or not. The following JIRAs had the same issue: > AMBARI-7195 > AMBARI-7315 > The fix for the above issues helps to resolve most part of the problem. But if the user happened to click again at the point when the last callback function has just completed (and thus, has made the "Next" button clickable again) but the next step has not yet completed its rendering, then the 2nd click gets processed again. The "current step" was already updated in the code to point to the next step, from the 1st click. So when this 2nd click calls the "next" function in the router, the subsequent step of the "current step" gets set as the current step. As a result we skip steps. -- This message was sent by Atlassian JIRA (v6.3.4#6332)