Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1377E181D9 for ; Wed, 27 Jan 2016 16:21:52 +0000 (UTC) Received: (qmail 43523 invoked by uid 500); 27 Jan 2016 16:21:17 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 43486 invoked by uid 500); 27 Jan 2016 16:21:17 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 43465 invoked by uid 99); 27 Jan 2016 16:21:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 16:21:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CFEBE1D9D57; Wed, 27 Jan 2016 16:21:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8756115333156947796==" MIME-Version: 1.0 Subject: Review Request 42857: Unit tests for Oozie are not executed (test run is successful) From: Dmytro Sen To: Vitalyi Brodetskyi , Andrew Onischuk , Dmitro Lisnichenko Cc: Dmytro Sen , Ambari Date: Wed, 27 Jan 2016 16:21:16 -0000 Message-ID: <20160127162116.12173.8900@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Dmytro Sen X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42857/ X-Sender: Dmytro Sen Reply-To: Dmytro Sen X-ReviewRequest-Repository: ambari --===============8756115333156947796== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42857/ ----------------------------------------------------------- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi Brodetskyi. Bugs: AMBARI-14815 https://issues.apache.org/jira/browse/AMBARI-14815 Repository: ambari Description ------- Test run reports that all tests passed. But Oozie tests are silently stopped with an exception Traceback (most recent call last): File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap self.run() File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run self._target(*self._args, **self._kwargs) File "/home/andrii/my/repos/ambari/ambari-server/src/test/python/unitTests.py", line 118, in stack_test_executor modules] File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName module = __import__('.'.join(parts_copy)) File "/home/andrii/my/repos/ambari/ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py", line 94 dfs_type = '', SyntaxError: keyword argument repeated unitTests.py should notify about the failure (in case of syntax error), not silently reject tests. Diffs ----- ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 5fc2cfb ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_client.py 4c1a9bc ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d167ef3 ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py 4033534 ambari-server/src/test/python/unitTests.py 7bc258d Diff: https://reviews.apache.org/r/42857/diff/ Testing ------- unit tests passed Thanks, Dmytro Sen --===============8756115333156947796==--