Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47E311817E for ; Tue, 26 Jan 2016 21:37:52 +0000 (UTC) Received: (qmail 30502 invoked by uid 500); 26 Jan 2016 21:37:52 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 30467 invoked by uid 500); 26 Jan 2016 21:37:52 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 30453 invoked by uid 99); 26 Jan 2016 21:37:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 21:37:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 620F7288E24; Tue, 26 Jan 2016 21:37:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4469274460852363187==" MIME-Version: 1.0 Subject: Re: Review Request 42824: Move Version Definition to its own endpoint From: Nate Cole To: Jonathan Hurley , Alejandro Fernandez Cc: Nate Cole , Ambari Date: Tue, 26 Jan 2016 21:37:51 -0000 Message-ID: <20160126213751.12172.27841@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nate Cole X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42824/ X-Sender: Nate Cole References: <20160126210054.12172.21997@reviews.apache.org> In-Reply-To: <20160126210054.12172.21997@reviews.apache.org> X-ReviewBoard-Diff-For: ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java X-ReviewBoard-Diff-For: ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java X-ReviewBoard-Diff-For: ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java Reply-To: Nate Cole X-ReviewRequest-Repository: ambari --===============4469274460852363187== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42824/ ----------------------------------------------------------- (Updated Jan. 26, 2016, 4:37 p.m.) Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBARI-14804 https://issues.apache.org/jira/browse/AMBARI-14804 Repository: ambari Description ------- For creating repositories from a Version Definition file, create a new endpoint. This is because unlike repo management, the stack is not known in advance. There are some validations missing from this code, but need to give the UI folks a "good" API to start with. Still just a couple of reviewers until stabilization. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java c7c5d61 ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java cce3764 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 92b14b7 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e367afe ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java c37abb5 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java e2e455b ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 450fd95 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 12d2091 Diff: https://reviews.apache.org/r/42824/diff/ Testing (updated) ------- Manual. Automated: Tests run: 3759, Failures: 0, Errors: 0, Skipped: 31 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 31:58.624s [INFO] Finished at: Tue Jan 26 16:11:54 EST 2016 [INFO] Final Memory: 34M/1397M [INFO] ------------------------------------------------------------------------ Thanks, Nate Cole --===============4469274460852363187==--