Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0FEB17676 for ; Tue, 26 Jan 2016 13:10:41 +0000 (UTC) Received: (qmail 15125 invoked by uid 500); 26 Jan 2016 13:10:41 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 15092 invoked by uid 500); 26 Jan 2016 13:10:41 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 15076 invoked by uid 99); 26 Jan 2016 13:10:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 13:10:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B7080288C8C; Tue, 26 Jan 2016 13:10:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3825857872579852709==" MIME-Version: 1.0 Subject: Review Request 42796: AMBARI-14798: Users cannot login with uppercase username From: Oliver Szabo To: Robert Levas , Sebastian Toader , Myroslav Papirkovskyy Cc: Oliver Szabo , Ambari Date: Tue, 26 Jan 2016 13:10:40 -0000 Message-ID: <20160126131040.12173.50265@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Oliver Szabo X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42796/ X-Sender: Oliver Szabo Reply-To: Oliver Szabo X-ReviewRequest-Repository: ambari --===============3825857872579852709== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42796/ ----------------------------------------------------------- Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sebastian Toader. Bugs: AMBARI-14798 https://issues.apache.org/jira/browse/AMBARI-14798 Repository: ambari Description ------- In Ambari DB, every username is stored in lowercase format. If a remote server store users in uppercase format (e.g. an active directory), the user cannot login with using uppercase letters in the username. (earlier, in ambari 2.1.2, UI forced to use lowercase username on login) Solution: Username converted lowercase on service level: predicate for usernames is defined based on the input of createResource() That is because: before rendering the resources for the response, this predicate has to be evaluated. (in that case: Users/user_name = 'Myuser'. If the response contains user_name = 'myuser', the response resource is filtered out) Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/services/ActiveWidgetLayoutService.java c4403df ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java 6861d3d ambari-server/src/main/java/org/apache/ambari/server/api/services/UserPrivilegeService.java 80769cf ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java fea5eca Diff: https://reviews.apache.org/r/42796/diff/ Testing ------- Unit testing done, FT: manually tested [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1:07:55.903s (Wall Clock) [INFO] Finished at: Tue Jan 26 13:17:14 CET 2016 [INFO] Final Memory: 85M/763M [INFO] ------------------------------------------------------------------------ Thanks, Oliver Szabo --===============3825857872579852709==--