Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5580205763097543738=="
MIME-Version: 1.0
Subject: Re: Review Request 42675: Clean up code for HAWQ IMMEDIATE CLUSTER
 STOP custom command
From: Matt <mithmatt@gmail.com>
To: jun aoki <jun.aoki.dev@gmail.com>,
 bhuvnesh chaudhary <bchaudhary@pivotal.io>, Lav Jain <ljain@pivotal.io>,
 Newton Alex <nalex@pivotal.io>,
 Oleksandr Diachenko <odiachenko@hortonworks.com>,
 Alexander Denissov <adenissov@apache.org>,
 Goutam Tadi <goutam.tadi1@gmail.com>
Cc: Matt <mithmatt@gmail.com>, Ambari <dev@ambari.apache.org>
Date: Mon, 25 Jan 2016 22:02:50 -0000
Message-ID: <20160125220250.25059.66497@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Matt <noreply@reviews.apache.org>
References: <20160125215720.12173.47633@reviews.apache.org>
In-Reply-To: <20160125215720.12173.47633@reviews.apache.org>
Reply-To: Matt <mithmatt@gmail.com>

--===============5580205763097543738==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 25, 2016, 1:57 p.m., jun aoki wrote:
> > ambari-web/app/views/main/service/item.js, line 209
> > <https://reviews.apache.org/r/42675/diff/1/?file=1218666#file1218666line209>
> >
> >     Matt, it seems to me that it is better to keep the semicolon, since the block(from line 201 to 209) is a single statement inside of the if statement.
> >     Could you confirm?

Yes, better to keep the semi-colon. Putting it back.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42675/#review116183
-----------------------------------------------------------


On Jan. 22, 2016, 3:56 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42675/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 3:56 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-14781
>     https://issues.apache.org/jira/browse/AMBARI-14781
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Delete additional code which is not required for the custom command HAWQ CLUSTER IMMEDIATE STOP
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/item.js 14552a1 
>   ambari-web/app/messages.js 34107f6 
>   ambari-web/app/utils/ajax/ajax.js 4762d34 
>   ambari-web/app/views/main/service/item.js 659a0a5 
> 
> Diff: https://reviews.apache.org/r/42675/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> Unit tests passed:
> 
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] Building Ambari Web 2.0.0.0-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> 
>   23090 tests complete (18 seconds)
>   164 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:12 min
> [INFO] Finished at: 2016-01-22T15:36:11-08:00
> [INFO] Final Memory: 12M/311M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>


--===============5580205763097543738==--