Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B7D418B7D for ; Sat, 23 Jan 2016 01:25:12 +0000 (UTC) Received: (qmail 59331 invoked by uid 500); 23 Jan 2016 01:25:12 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 59298 invoked by uid 500); 23 Jan 2016 01:25:12 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 59275 invoked by uid 99); 23 Jan 2016 01:25:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jan 2016 01:25:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 90CB5282FB6; Sat, 23 Jan 2016 01:25:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6644642112300436548==" MIME-Version: 1.0 Subject: Re: Review Request 42675: Clean up code for HAWQ IMMEDIATE CLUSTER STOP custom command From: Alexander Denissov To: jun aoki , bhuvnesh chaudhary , Lav Jain , Newton Alex , Oleksandr Diachenko , Alexander Denissov , Goutam Tadi Cc: Matt , Ambari Date: Sat, 23 Jan 2016 01:25:11 -0000 Message-ID: <20160123012511.32315.72943@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Denissov X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42675/ X-Sender: Alexander Denissov X-ReviewBoard-ShipIt: 1 References: <20160122235640.32314.50274@reviews.apache.org> In-Reply-To: <20160122235640.32314.50274@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Alexander Denissov X-ReviewRequest-Repository: ambari --===============6644642112300436548== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42675/#review115962 ----------------------------------------------------------- Ship it! Ship It! - Alexander Denissov On Jan. 22, 2016, 11:56 p.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42675/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 11:56 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko. > > > Bugs: AMBARI-14781 > https://issues.apache.org/jira/browse/AMBARI-14781 > > > Repository: ambari > > > Description > ------- > > Delete additional code which is not required for the custom command HAWQ CLUSTER IMMEDIATE STOP > > > Diffs > ----- > > ambari-web/app/controllers/main/service/item.js 14552a1 > ambari-web/app/messages.js 34107f6 > ambari-web/app/utils/ajax/ajax.js 4762d34 > ambari-web/app/views/main/service/item.js 659a0a5 > > Diff: https://reviews.apache.org/r/42675/diff/ > > > Testing > ------- > > Manually Tested > > Unit tests passed: > > [INFO] > [INFO] ------------------------------------------------------------------------ > [INFO] Building Ambari Web 2.0.0.0-SNAPSHOT > [INFO] ------------------------------------------------------------------------ > [INFO] > > 23090 tests complete (18 seconds) > 164 tests pending > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 01:12 min > [INFO] Finished at: 2016-01-22T15:36:11-08:00 > [INFO] Final Memory: 12M/311M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Matt > > --===============6644642112300436548==--