Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 829E417C7A for ; Fri, 22 Jan 2016 10:11:49 +0000 (UTC) Received: (qmail 87393 invoked by uid 500); 22 Jan 2016 10:11:49 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 87361 invoked by uid 500); 22 Jan 2016 10:11:49 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 87344 invoked by uid 99); 22 Jan 2016 10:11:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 10:11:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A8FAB282E3F; Fri, 22 Jan 2016 10:11:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8427857653800131251==" MIME-Version: 1.0 Subject: Re: Review Request 42572: Ambari server throws error when unused configs are present in blueprint From: "Laszlo Puskas" To: "Laszlo Puskas" , "Sumit Mohanty" , "Sandor Magyari" , "Sebastian Toader" , "Robert Nettleton" Cc: "Oliver Szabo" , "Ambari" Date: Fri, 22 Jan 2016 10:11:47 -0000 Message-ID: <20160122101147.32039.68469@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Laszlo Puskas" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42572/ X-Sender: "Laszlo Puskas" References: <20160122100554.32038.85278@reviews.apache.org> In-Reply-To: <20160122100554.32038.85278@reviews.apache.org> Reply-To: "Laszlo Puskas" X-ReviewRequest-Repository: ambari --===============8427857653800131251== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42572/#review115820 ----------------------------------------------------------- Ship it! Ship It! - Laszlo Puskas On Jan. 22, 2016, 10:05 a.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42572/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 10:05 a.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-14745 > https://issues.apache.org/jira/browse/AMBARI-14745 > > > Repository: ambari > > > Description > ------- > > In case of a blueprint contains unused config types -> updaters can apply on the unused properties. In same cases this can cause exceptions. E.g.: single host updater on a property -> no host found for a service. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java c719009 > ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74 > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java 8afff46 > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java dd66b1b > ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java e971e03 > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7810f92 > > Diff: https://reviews.apache.org/r/42572/diff/ > > > Testing > ------- > > Unit testing is in progress. > FT: blueprints with unused config types. > > > Thanks, > > Oliver Szabo > > --===============8427857653800131251==--