Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65A3418225 for ; Mon, 18 Jan 2016 23:42:57 +0000 (UTC) Received: (qmail 55832 invoked by uid 500); 18 Jan 2016 23:42:57 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 55795 invoked by uid 500); 18 Jan 2016 23:42:57 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 55778 invoked by uid 99); 18 Jan 2016 23:42:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 23:42:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0DE5C281E3D; Mon, 18 Jan 2016 23:42:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3697900700031365986==" MIME-Version: 1.0 Subject: Re: Review Request 42369: Kerberos automation logic should use stack advisor when determining configuration updates From: "Oliver Szabo" To: "Srimanth Gunturi" , "Sandor Magyari" , "Robert Nettleton" Cc: "Robert Levas" , "Ambari" , "Oliver Szabo" Date: Mon, 18 Jan 2016 23:42:56 -0000 Message-ID: <20160118234256.32038.32868@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Oliver Szabo" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42369/ X-Sender: "Oliver Szabo" References: <20160118230833.32038.12144@reviews.apache.org> In-Reply-To: <20160118230833.32038.12144@reviews.apache.org> Reply-To: "Oliver Szabo" X-ReviewRequest-Repository: ambari --===============3697900700031365986== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42369/#review115080 ----------------------------------------------------------- ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java (line 46) Just a small thing. Is using wildcard for imports allowed for ambari? if does not, fix it - Oliver Szabo On Jan. 18, 2016, 11:08 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42369/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 11:08 p.m.) > > > Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi. > > > Bugs: AMBARI-14698 > https://issues.apache.org/jira/browse/AMBARI-14698 > > > Repository: ambari > > > Description > ------- > > Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4 > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java dcedd51 > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1 > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651 > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd > ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6 > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549 > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9 > > Diff: https://reviews.apache.org/r/42369/diff/ > > > Testing > ------- > > Manualled tested: > - creating a cluster via the UI then enabling Kerberos and disabling Kerberos > - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos > - creating a Kerberized cluster via Blueprints then disabling Kerberos > > # Local test results: > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 1:08:31.852s > [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016 > [INFO] Final Memory: 56M/1632M > [INFO] ------------------------------------------------------------------------ > > # Jenkins test results: > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 01:54 h > [INFO] Finished at: 2016-01-16T05:54:09+00:00 > [INFO] Final Memory: 135M/643M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > > --===============3697900700031365986==--