Return-Path: 
 <dev-return-103494-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 30DCA1878E
	for <apmail-ambari-dev-archive@www.apache.org>;
 Mon, 18 Jan 2016 19:47:50 +0000 (UTC)
Received: (qmail 96289 invoked by uid 500); 18 Jan 2016 19:47:50 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 96252 invoked by uid 500); 18 Jan 2016 19:47:50 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 96235 invoked by uid 99); 18 Jan 2016 19:47:49 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 19:47:49 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 74783281CE7;
	Mon, 18 Jan 2016 19:47:48 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4643806494504646340=="
MIME-Version: 1.0
Subject: Re: Review Request 42337: AMBARI-14678. RU - Oozie HA,
 Service Check fails since the pre-upgrade directive has multiple tasks that
 should run only on the specified hosts
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Jayush Luniya" <jluniya@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Dmytro Grinenko" <hapy.lestat@gmail.com>,
 "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Alejandro Fernandez" <afernandez@hortonworks.com>
Date: Mon, 18 Jan 2016 19:47:48 -0000
Message-ID: <20160118194748.32039.60257@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/42337/
X-Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20160115024535.26792.35061@reviews.apache.org>
In-Reply-To: <20160115024535.26792.35061@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============4643806494504646340==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42337/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 7:47 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya, and Nate Cole.


Changes
-------

Addressed comments.


Bugs: AMBARI-14678
    https://issues.apache.org/jira/browse/AMBARI-14678


Repository: ambari


Description
-------

STR:
HDP 2.2
Multiple Oozie Servers
RU to HDP 2.3

The pre-upgrade directive for Oozie has 
```
<pre-upgrade>
  <task xsi:type="execute" hosts="all" summary="Shut down all Oozie servers">
    <script>scripts/oozie_server.py</script>
    <function>stop</function>
  </task>

  <task xsi:type="execute" hosts="any" summary="Upgrading the database and creating a new sharelib">
    <script>scripts/oozie_server_upgrade.py</script>
    <function>upgrade_oozie_database_and_sharelib</function>
  </task>
</pre-upgrade>
```

Notice that the first task runs on all hosts, and the second task runs on exactly one random host. The problem is that the scheduler runs both tasks in one stage on the union of these hosts. Therefore, the 2nd task runs on the wrong set of hosts.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java aa852bd 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java b0df83f 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 980f88e 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java 69b3f8b 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java 057c310 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 2cf9da9 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml cbd9c2a 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 816fe13 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml 5166c4b 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 8b2f2a3 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 375da12 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml ea3d6a6 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 34423f9 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50c8584 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 876342c 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f145de1 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml a9ee860 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml b8bd1ee 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e61942 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/OOZIE/metainfo.xml PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml 0e6d914 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 4f71b4a 

Diff: https://reviews.apache.org/r/42337/diff/


Testing
-------

Verified during RU from HDP 2.2 to 2.3 with multiple Oozie Servers.

Waiting for unit test results.


Thanks,

Alejandro Fernandez


--===============4643806494504646340==--