Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D55E182FA for ; Fri, 15 Jan 2016 23:42:49 +0000 (UTC) Received: (qmail 58433 invoked by uid 500); 15 Jan 2016 23:42:49 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 58404 invoked by uid 500); 15 Jan 2016 23:42:49 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 58388 invoked by uid 99); 15 Jan 2016 23:42:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2016 23:42:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7B3BF281796; Fri, 15 Jan 2016 23:42:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1968538320028160609==" MIME-Version: 1.0 Subject: Review Request 42369: Kerberos automation logic should use stack advisor when determining configuration updates From: "Robert Levas" To: "Srimanth Gunturi" , "Sandor Magyari" , "Robert Nettleton" Cc: "Robert Levas" , "Ambari" Date: Fri, 15 Jan 2016 23:42:48 -0000 Message-ID: <20160115234248.26792.52209@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42369/ X-Sender: "Robert Levas" Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============1968538320028160609== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42369/ ----------------------------------------------------------- Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi. Bugs: AMBARI-14698 https://issues.apache.org/jira/browse/AMBARI-14698 Repository: ambari Description ------- Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06 ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4 ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27 ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651 ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6 ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549 ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9 Diff: https://reviews.apache.org/r/42369/diff/ Testing ------- Manualled tested: - creating a cluster via the UI then enabling Kerberos and disabling Kerberos - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos - creating a Kerberized cluster via Blueprints then disabling Kerberos # Local test results: PASSED # Jenkins test results: PENDING Thanks, Robert Levas --===============1968538320028160609==--