Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBCC9188B4 for ; Fri, 15 Jan 2016 19:26:47 +0000 (UTC) Received: (qmail 13605 invoked by uid 500); 15 Jan 2016 19:26:47 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 13562 invoked by uid 500); 15 Jan 2016 19:26:47 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 13543 invoked by uid 99); 15 Jan 2016 19:26:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2016 19:26:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 06AB5280ED5; Fri, 15 Jan 2016 19:26:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1044288557243070769==" MIME-Version: 1.0 Subject: Re: Review Request 42051: [AMBARI-14561] Configuration changes of spark thrift server for Spark 1.6 From: "Jeff Zhang" To: "Alejandro Fernandez" , "Sumit Mohanty" , "Saisai Shao" Cc: "Matt" , "Ambari" , "Jeff Zhang" Date: Fri, 15 Jan 2016 19:26:45 -0000 Message-ID: <20160115192645.26793.60644@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jeff Zhang" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42051/ X-Sender: "Jeff Zhang" References: <20160115185120.26793.45737@reviews.apache.org> In-Reply-To: <20160115185120.26793.45737@reviews.apache.org> Reply-To: "Jeff Zhang" X-ReviewRequest-Repository: ambari --===============1044288557243070769== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42051/ ----------------------------------------------------------- (Updated Jan. 15, 2016, 7:26 p.m.) Review request for Ambari, Alejandro Fernandez, Saisai Shao, and Sumit Mohanty. Bugs: AMBARI-14561 https://issues.apache.org/jira/browse/AMBARI-14561 Repository: ambari Description ------- This is for HDP stack, in HDP stack, we'd like to do following changes for spark thrift server - Remove advanced properties except queue name - Use yarn-client mode - Enable Dynamic Resource Allocation - Enable Fair scheduling policy Diffs (updated) ----- ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py c3ffc7b ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 68240bd ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 4b38572 ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 6c0e393 Diff: https://reviews.apache.org/r/42051/diff/ Testing ------- This patch doesn't solve the issue completly. The weird thing is that the configuration in HDP 2.3's spark-thrift-sparkconf.xml will be appended to HDP-2.4's spark-thrift-sparkconf.xml. And what I want is remove some configuration in 2.3. And actually I make Spark 1.6 of HDP 2.4 extend Spark 1.2 in common-services, not sure why it still use spark-thrift-sparkconf.xml in HDP 2.3 Thanks, Jeff Zhang --===============1044288557243070769==--