Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F2C3B18455 for ; Fri, 15 Jan 2016 17:44:57 +0000 (UTC) Received: (qmail 20141 invoked by uid 500); 15 Jan 2016 17:44:57 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 20102 invoked by uid 500); 15 Jan 2016 17:44:57 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 20087 invoked by uid 99); 15 Jan 2016 17:44:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2016 17:44:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B21A028148E; Fri, 15 Jan 2016 17:44:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5966910905832264107==" MIME-Version: 1.0 Subject: Review Request 42357: Unnecessary multiple TreeMap creation From: "Dmytro Sen" To: "Aravindan Vijayan" , "Myroslav Papirkovskyy" , "Sid Wagle" Cc: "Dmytro Sen" , "Ambari" Date: Fri, 15 Jan 2016 17:44:56 -0000 Message-ID: <20160115174456.26386.51212@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42357/ X-Sender: "Dmytro Sen" Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============5966910905832264107== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42357/ ----------------------------------------------------------- Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid Wagle. Bugs: AMBARI-14694 https://issues.apache.org/jira/browse/AMBARI-14694 Repository: ambari Description ------- In TimelineReadHelper TreeMap sortedByTimeMetrics = new TreeMap( PhoenixHBaseAccessor.readMetricFromJSON(rs.getString("METRICS"))); but readMetricFromJSON returns the TreeMap it can lead to memory wasting Diffs ----- ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java c5d7b0c ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java dc27614 Diff: https://reviews.apache.org/r/42357/diff/ Testing ------- [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] ambari-metrics .................................... SUCCESS [2.638s] [INFO] Ambari Metrics Common ............................. SUCCESS [5.221s] [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [5.875s] [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.969s] [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [4.551s] [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [11.473s] [INFO] Ambari Metrics Collector .......................... SUCCESS [2:40.199s] [INFO] Ambari Metrics Monitor ............................ SUCCESS [5.288s] [INFO] Ambari Metrics Assembly ........................... SUCCESS [2:29.464s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] -------------------- Thanks, Dmytro Sen --===============5966910905832264107==--