Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C7A9A189C4 for ; Tue, 12 Jan 2016 22:05:17 +0000 (UTC) Received: (qmail 55268 invoked by uid 500); 12 Jan 2016 22:05:17 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 55233 invoked by uid 500); 12 Jan 2016 22:05:17 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 55217 invoked by uid 99); 12 Jan 2016 22:05:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 22:05:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE22E280AFE; Tue, 12 Jan 2016 22:05:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2513725906114493055==" MIME-Version: 1.0 Subject: Re: Review Request 42204: AMBARI-14636 : Add stack advisor validation for AMS distributed properties From: "Aravindan Vijayan" To: "Sid Wagle" , "Sumit Mohanty" , "Dmytro Sen" Cc: "Aravindan Vijayan" , "Ambari" Date: Tue, 12 Jan 2016 22:05:16 -0000 Message-ID: <20160112220516.26793.8363@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aravindan Vijayan" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42204/ X-Sender: "Aravindan Vijayan" References: <20160112193502.26792.76621@reviews.apache.org> In-Reply-To: <20160112193502.26792.76621@reviews.apache.org> Reply-To: "Aravindan Vijayan" X-ReviewRequest-Repository: ambari --===============2513725906114493055== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42204/ ----------------------------------------------------------- (Updated Jan. 12, 2016, 10:05 p.m.) Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-14636 https://issues.apache.org/jira/browse/AMBARI-14636 Repository: ambari Description ------- Based on the value of the timeline.metrics.service.operation.mode config in ams-site, the following configs and respective values are recommended and validated. hbase.rootdir hbase.cluster.distributed. hbase.zookeeper.property.clientPort dfs.client.read.shortcircuit Value Guidance Matrix. timeline.metrics.service.operation.mode embedded distributed hbase.rootdir file:///var/lib/ambari-metrics-collector/hbase core-site:fs.defaultFs + /user/ams/hbase hbase.cluster.distributed. false true hbase.zookeeper.property.clientPort 61181 (default) 2181 (cluster Zk port) dfs.client.read.shortcircuit true true (if DN present along with collector, else false) Diffs ----- ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml 5f0ac12 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py a4c602e ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c37f2ab ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 983109a Diff: https://reviews.apache.org/r/42204/diff/ Testing (updated) ------- Manual testing done. ambari-server python unit tests pass. Unit tests succeeded locally. [INFO] Ambari Main ....................................... SUCCESS [6.451s] [INFO] Apache Ambari Project POM ......................... SUCCESS [0.036s] [INFO] Ambari Web ........................................ SUCCESS [45.123s] [INFO] Ambari Views ...................................... SUCCESS [3.147s] [INFO] Ambari Admin View ................................. SUCCESS [11.186s] [INFO] ambari-metrics .................................... SUCCESS [0.830s] [INFO] Ambari Metrics Common ............................. SUCCESS [2.092s] [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [4.337s] [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.134s] [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.017s] [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.220s] [INFO] Ambari Metrics Collector .......................... SUCCESS [1:03.301s] [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.517s] [INFO] Ambari Metrics Assembly ........................... SUCCESS [10.586s] [INFO] Ambari Server ..................................... SUCCESS [1:19:28.242s] [INFO] Ambari Agent ...................................... SUCCESS [9.153s] [INFO] Ambari Client ..................................... SUCCESS [0.050s] [INFO] Ambari Python Client .............................. SUCCESS [0.473s] [INFO] Ambari Groovy Client .............................. SUCCESS [10.459s] [INFO] Ambari Shell ...................................... SUCCESS [0.034s] [INFO] Ambari Python Shell ............................... SUCCESS [0.039s] [INFO] Ambari Groovy Shell ............................... SUCCESS [7.190s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1:22:32.356s [INFO] Finished at: Tue Jan 12 14:01:09 PST 2016 [INFO] Final Memory: 90M/1369M [INFO] ------------------------------------------------------------------------ Submitted patch through Apache. Thanks, Aravindan Vijayan --===============2513725906114493055==--