Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6905859020188197270=="
MIME-Version: 1.0
Subject: Re: Review Request 41973: AMBARI-14550 : Ranger KMS install from
 Ambari - Add ability to skip DB/DB user setup
From: "Gautam Borad" <gborad@gmail.com>
To: "Mahadev Konar" <mahadev@apache.org>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Selvamohan Neethiraj" <sneethiraj@hortonworks.com>,
 "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jaimin Jetly" <jaimin@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>,
 "Velmurugan Periasamy" <vperiasamy@hortonworks.com>
Cc: "Gautam Borad" <gborad@gmail.com>, "Ambari" <dev@ambari.apache.org>
Date: Tue, 12 Jan 2016 12:10:29 -0000
Message-ID: <20160112121029.26386.2591@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Gautam Borad" <noreply@reviews.apache.org>
References: <20160107073402.26044.9028@reviews.apache.org>
In-Reply-To: <20160107073402.26044.9028@reviews.apache.org>
Reply-To: "Gautam Borad" <gborad@gmail.com>

--===============6905859020188197270==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41973/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 12:10 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Patch contains unit test fixes.

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.upgrade.UpgradeCatalog221Test
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 75.972 sec

Results :

Tests run: 11, Failures: 0, Errors: 0, Skipped: 0


Bugs: AMBARI-14550
    https://issues.apache.org/jira/browse/AMBARI-14550


Repository: ambari


Description
-------

Patch contains stack level changes to add Smart Config options to manage Ranger KMS DB config properties. 

Now user will have flexibility to Turn On / Off Setup DB and DB Users flag. 
  Based on the toggle - user needs to provide credentials.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java 9c947a1 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/dbks-site.xml 8291e02 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml 10c14ac 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml 6c37b94 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml d5b0aa7 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-policymgr-ssl.xml fb4a4e6 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 79353e6 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 2e2e52d 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml b1a5584 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/themes/theme_version_1.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 3970844 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java eba3391 
  ambari-server/src/test/python/stacks/2.3/configs/default.json 21bff13 
  ambari-web/app/models/configs/objects/service_config.js 5d827b7 
  ambari-web/app/models/stack_service.js 957d7ae 

Diff: https://reviews.apache.org/r/41973/diff/


Testing
-------

Performed following test cases : 

1) Setup Cluster with Ranger KMS using database flavors MYSQL, ORACLE with Setup DB and DB Users flag as off.
2) Performed Ambari upgrade from older version using all database flavors to latest version to check impact of changes in smart configs.

----------------------------------------------------------------------
Ran 271 tests in 6.559s

OK
----------------------------------------------------------------------
Total run:891
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


--===============6905859020188197270==--