Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8973674918032592287=="
MIME-Version: 1.0
Subject: Re: Review Request 42026: Rest API returns incorrect cluster creation
 request status using Blueprints until nodes join the cluster
From: "Sumit Mohanty" <smohanty@hortonworks.com>
To: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>,
 "Robert Nettleton" <rnettleton@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Sebastian Toader" <stoader@hortonworks.com>
Date: Sat, 09 Jan 2016 20:16:44 -0000
Message-ID: <20160109201644.1693.74153@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sumit Mohanty" <noreply@reviews.apache.org>
References: <20160109200205.1693.79563@reviews.apache.org>
In-Reply-To: <20160109200205.1693.79563@reviews.apache.org>
Reply-To: "Sumit Mohanty" <smohanty@hortonworks.com>

--===============8973674918032592287==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42026/#review113625
-----------------------------------------------------------


ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java (line 56)
<https://reviews.apache.org/r/42026/#comment174387>

    Looks like bad merge


- Sumit Mohanty


On Jan. 9, 2016, 8:02 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42026/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 8:02 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14551
>     https://issues.apache.org/jira/browse/AMBARI-14551
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. If the cluster is provisioned using Blueprint and if there are no tasks created verify the status of the topology logical request (that will exist only for Blueprints) to determine if the request was prior completed or it's waiting for hosts to register and be assigned to host groups. 
> 2. Upon host deletion delete the topology host requests associated with the deleted host.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java f0d9fde 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 1a71afa 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntity.java 046bbd8 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java ca09ab8 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java ad7c8fd 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 80d19d2 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java 03ef06d 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java 178adc5 
> 
> Diff: https://reviews.apache.org/r/42026/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on the 3 node cluster created using Blueprint (before agents registered with ambari server)
> 
> Unit tests:
> Results :
> 
> Tests run: 3741, Failures: 0, Errors: 0, Skipped: 29
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


--===============8973674918032592287==--