Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B7BE185A9 for ; Sat, 9 Jan 2016 03:31:59 +0000 (UTC) Received: (qmail 31164 invoked by uid 500); 9 Jan 2016 03:31:59 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 31117 invoked by uid 500); 9 Jan 2016 03:31:59 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 31104 invoked by uid 99); 9 Jan 2016 03:31:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Jan 2016 03:31:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6841A1DD5E9; Sat, 9 Jan 2016 03:31:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8426184341039033843==" MIME-Version: 1.0 Subject: Re: Review Request 42060: Import visualsearch.js library to ambari-web From: "Yusaku Sako" To: "Yusaku Sako" Cc: "Richard Zang" , "Ambari" Date: Sat, 09 Jan 2016 03:31:58 -0000 Message-ID: <20160109033158.1692.1519@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Yusaku Sako" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42060/ X-Sender: "Yusaku Sako" References: <20160108033100.26044.43238@reviews.apache.org> In-Reply-To: <20160108033100.26044.43238@reviews.apache.org> Reply-To: "Yusaku Sako" X-ReviewRequest-Repository: ambari --===============8426184341039033843== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42060/#review113600 ----------------------------------------------------------- Ship it! Ship It! - Yusaku Sako On Jan. 8, 2016, 3:30 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42060/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 3:30 a.m.) > > > Review request for Ambari and Yusaku Sako. > > > Bugs: AMBARI-14583 > https://issues.apache.org/jira/browse/AMBARI-14583 > > > Repository: ambari > > > Description > ------- > > visualsearch.js https://documentcloud.github.io/visualsearch/ > will be used as the library for host page combo filter. We need to import this library into ambari-web. > > Notice: 'ui-autocomplete' has been changed to 'autocomplete' in visualsearch.js for compatibility with jquery ui 1.8.23 > > > Diffs > ----- > > LICENSE.txt 14f884e > ambari-web/app/config.js 098a0dc > ambari-web/app/templates/main/host.hbs 66d38e4 > ambari-web/app/templates/main/host/combo_search_box.hbs PRE-CREATION > ambari-web/app/views.js 3a4fb4d > ambari-web/app/views/main/host/combo_search_box.js PRE-CREATION > ambari-web/config.coffee 2922593 > ambari-web/karma.conf.js 3a54978 > ambari-web/vendor/scripts/backbone.js PRE-CREATION > ambari-web/vendor/scripts/jquery.ui.autocomplete.js PRE-CREATION > ambari-web/vendor/scripts/jquery.ui.position.js PRE-CREATION > ambari-web/vendor/scripts/underscore.js PRE-CREATION > ambari-web/vendor/scripts/visualsearch.js PRE-CREATION > ambari-web/vendor/styles/visualsearch.css PRE-CREATION > > Diff: https://reviews.apache.org/r/42060/diff/ > > > Testing > ------- > > Manually tested on live cluster. All unit tests passed. > 22941 tests complete (16 seconds) > 163 tests pending > > > Thanks, > > Richard Zang > > --===============8426184341039033843==--