Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A080718F88 for ; Fri, 8 Jan 2016 06:10:36 +0000 (UTC) Received: (qmail 45598 invoked by uid 500); 8 Jan 2016 06:10:36 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 45558 invoked by uid 500); 8 Jan 2016 06:10:36 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 45541 invoked by uid 99); 8 Jan 2016 06:10:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2016 06:10:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EE673298CF8; Fri, 8 Jan 2016 06:10:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6623117488462064233==" MIME-Version: 1.0 Subject: Re: Review Request 42051: [AMBARI-14561] Configuration changes of spark thrift server for Spark 1.6 From: "Matt" To: "Sumit Mohanty" Cc: "Matt" , "Jeff Zhang" , "Ambari" Date: Fri, 08 Jan 2016 06:10:35 -0000 Message-ID: <20160108061035.26043.30413@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Matt" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/42051/ X-Sender: "Matt" References: <20160108011830.26044.63900@reviews.apache.org> In-Reply-To: <20160108011830.26044.63900@reviews.apache.org> Reply-To: "Matt" X-ReviewRequest-Repository: ambari --===============6623117488462064233== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42051/#review113422 ----------------------------------------------------------- Ship it! Ship It! - Matt On Jan. 7, 2016, 5:18 p.m., Jeff Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42051/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 5:18 p.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-14561 > https://issues.apache.org/jira/browse/AMBARI-14561 > > > Repository: ambari > > > Description > ------- > > This is for HDP stack, in HDP stack, we'd like to do following changes for spark thrift server > - Remove advanced properties except queue name > - Use yarn-client mode > - Enable Dynamic Resource Allocation > - Enable Fair scheduling policy > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 4b38572 > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/templates/spark-thrift-fairscheduler.xml.j2 PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-hive-site-override.xml PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 6c0e393 > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/quicklinks/quicklinks.json PRE-CREATION > > Diff: https://reviews.apache.org/r/42051/diff/ > > > Testing > ------- > > This patch doesn't solve the issue completly. The weird thing is that the configuration in HDP 2.3's spark-thrift-sparkconf.xml will be appended to HDP-2.4's spark-thrift-sparkconf.xml. And what I want is remove some configuration in 2.3. And actually I make Spark 1.6 of HDP 2.4 extend Spark 1.2 in common-services, not sure why it still use spark-thrift-sparkconf.xml in HDP 2.3 > > > Thanks, > > Jeff Zhang > > --===============6623117488462064233==--