Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0110418C3A for ; Wed, 6 Jan 2016 18:13:36 +0000 (UTC) Received: (qmail 88111 invoked by uid 500); 6 Jan 2016 18:13:35 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 88077 invoked by uid 500); 6 Jan 2016 18:13:35 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 88060 invoked by uid 99); 6 Jan 2016 18:13:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2016 18:13:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 44B1F29827F; Wed, 6 Jan 2016 18:13:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5262208121745520774==" MIME-Version: 1.0 Subject: Re: Review Request 38487: Enable JPA statement caching (internal/external) From: "Alejandro Fernandez" To: "Myroslav Papirkovskyy" , "Sebastian Toader" , "Robert Nettleton" , "Jonathan Hurley" Cc: "Ambari" , "Oliver Szabo" , "Alejandro Fernandez" Date: Wed, 06 Jan 2016 18:13:34 -0000 Message-ID: <20160106181334.1209.33829@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38487/ X-Sender: "Alejandro Fernandez" References: <20160106145444.26044.97972@reviews.apache.org> In-Reply-To: <20160106145444.26044.97972@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============5262208121745520774== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38487/#review113100 ----------------------------------------------------------- Ship it! Ship It! - Alejandro Fernandez On Jan. 6, 2016, 2:54 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38487/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 2:54 p.m.) > > > Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-13036 > https://issues.apache.org/jira/browse/AMBARI-13036 > > > Repository: ambari > > > Description > ------- > > Problem: > > Ambari does not cache database statements which leads to excessive parsing. > > Solution: > > Added internal and external statement caching feature to Ambari. Caching is not used by default (for c3p0: if max statements is 0, caching is disabled, for insternal caching its decided based on a boolean flag) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java e3686ac > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java a40fae6 > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 074fbb4 > > Diff: https://reviews.apache.org/r/38487/diff/ > > > Testing > ------- > > Unit testing done. > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 01:31 h > [INFO] Finished at: 2015-09-17T17:21:55+00:00 > [INFO] Final Memory: 48M/605M > [INFO] ------------------------------------------------------------------------ > > Functional testing: > Locally: done on Postgres & MySQL databases > > > Thanks, > > Oliver Szabo > > --===============5262208121745520774==--