ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-14672) Creating a user with a mixed-case username behaves strangely
Date Thu, 14 Jan 2016 23:54:40 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099155#comment-15099155
] 

Hadoop QA commented on AMBARI-14672:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12782341/AMBARI-14672.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.controller.internal.UpgradeResourceProviderTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/4921//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/4921//console

This message is automatically generated.

> Creating a user with a mixed-case username behaves strangely
> ------------------------------------------------------------
>
>                 Key: AMBARI-14672
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14672
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.1.1
>            Reporter: Greg Hill
>            Assignee: Greg Hill
>            Priority: Minor
>         Attachments: AMBARI-14672.patch
>
>
> If you create a user with some capital letters in the username, Ambari accepts the request
and creates a user with the lowercase version of that username.  However, if you then do a
GET on the original username, Ambari gives a 200 response but an empty response body:
> {noformat}
> GET /api/v1/users/MixedCase
> 200 OK
> <empty response>
> GET /api/v1/users/mixedcase
> 200 OK
> {
>   "href" : "https://ambari-8d6c17ae32685572aa82f82b813138a1.cbdptest.com/api/v1/users/mixedcase",
>   "Users" : {
>     "active" : true,
>     "admin" : false,
>     "groups" : [ ],
>     "ldap_user" : false,
>     "user_name" : "mixedcase"
>   },
>   "widget_layouts" : [ ],
>   "privileges" : [ ]
> }
> {noformat}
> Ambari should throw a 404 error at a minimum, but better yet, just lowercase the username
requested and return the right user.  Since we silently lowercase it on POST, we should do
the same on GET, IMO.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message