ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keta Patel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-14574) multiple clicks on "Next" button causes skipping of steps while installing a cluster
Date Mon, 11 Jan 2016 23:34:40 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092941#comment-15092941
] 

Keta Patel commented on AMBARI-14574:
-------------------------------------

The issue is seen in most of the wizard installation steps because the properties responsible
to disable the duplicate submit calls are unable to account for the transition between the
'actions' and 'render' used by the Ember framework. 
The installation steps use the 'submit' function from controllers or the 'next' function from
installer to set the properties used in the checks for processing the Next button clicks.
These properties are reset in the views if the next step renders or in the same controller/installer
in case of failures. Hence, the property that is responsible for the checks must be accessible
across controllers, installer and views. 
The fix proposed for this issue involves creating a new property 'nextBtnClickInProgress'
in the router, hence accessible in all the above places. This property is set at suitable
places in the controller/installer and reset in the views or appropriate places in the controllers
(failure cases).

[~aantonenko], since you had resolved the same issue in AMBARI-7195 and AMBARI-7315, could
you please provide your feedback on the way I have proposed the fix in the patch attached
under the name "AMBARI-14574.patch". This patch is still not complete (test cases remain).


The following steps have changes made (the other steps did not have this issue):
Step 1
Step 3
Step 4
Step 5
Step 7

> multiple clicks on "Next" button causes skipping of steps while installing a cluster
> ------------------------------------------------------------------------------------
>
>                 Key: AMBARI-14574
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14574
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.1.1
>            Reporter: Keta Patel
>            Assignee: Keta Patel
>         Attachments: AMBARI-14574.patch
>
>
> On installation wizard, multiple clicks on the "Next" button can cause skipping of steps.
The timing of the 2nd click decides if that click will be processed again or not. The following
JIRAs had the same issue:
> AMBARI-7195
> AMBARI-7315
> The fix for the above issues helps to resolve most part of the problem. But if the user
happened to click again at the point when the last callback function has just completed (and
thus, has made the "Next" button clickable again) but the next step has not yet completed
its rendering, then the 2nd click gets processed again. The "current step" was already updated
in the code to point to the next step, from the 1st click. So when this 2nd click calls the
"next" function in the router, the subsequent step of the "current step" gets set as the current
step. As a result we skip steps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message