ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonenko Alexander (JIRA)" <>
Subject [jira] [Commented] (AMBARI-14574) multiple clicks on "Next" button causes skipping of steps while installing a cluster
Date Fri, 22 Jan 2016 13:01:39 GMT


Antonenko Alexander commented on AMBARI-14574:

please update your patch to cover

 ✖ 1 of 23079 tests failed:

  1) Ambari Web Unit tests "after each" hook:
     TypeError: 'undefined' is not a function (evaluating 'App.ajax.send.restore()')
      at file:///Users/alex/Documents/github/ambari-vagrant/centos6.4/ambari/ambari-web/public/test/tests.js:384
      at file:///Users/alex/Documents/github/ambari-vagrant/centos6.4/ambari/ambari-web/node_modules/mocha/mocha.js:4039
      at next (file:///Users/alex/Documents/github/ambari-vagrant/centos6.4/ambari/ambari-web/node_modules/mocha/mocha.js:4303)
      at file:///Users/alex/Documents/github/ambari-vagrant/centos6.4/ambari/ambari-web/node_modules/mocha/mocha.js:4307
      at timeslice (file:///Users/alex/Documents/github/ambari-vagrant/centos6.4/ambari/ambari-web/node_modules/mocha/mocha.js:5279)

> multiple clicks on "Next" button causes skipping of steps while installing a cluster
> ------------------------------------------------------------------------------------
>                 Key: AMBARI-14574
>                 URL:
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.1.1
>            Reporter: Keta Patel
>            Assignee: Keta Patel
>         Attachments: AMBARI-14574.patch, AMBARI-14574_Jan19_only_nextBtnClickInProgress.patch,
AMBARI-14574_Jan19_with_transitionInProgress.patch, AMBARI-14574_Jan20_manual_testing.patch,
AMBARI-14574_Jan20_with_fix.patch, attempt_1_controller.tiff, attempt_1_installer.tiff, attempt_2_controller.tiff,
attempt_2_installer.tiff, attempt_3_adding_check_for_step1.tiff, attempt_3_removing_check_from_step3.tiff
> On installation wizard, multiple clicks on the "Next" button can cause skipping of steps.
The timing of the 2nd click decides if that click will be processed again or not. The following
JIRAs had the same issue:
> AMBARI-7195
> AMBARI-7315
> The fix for the above issues helps to resolve most part of the problem. But if the user
happened to click again at the point when the last callback function has just completed (and
thus, has made the "Next" button clickable again) but the next step has not yet completed
its rendering, then the 2nd click gets processed again. The "current step" was already updated
in the code to point to the next step, from the 1st click. So when this 2nd click calls the
"next" function in the router, the subsequent step of the "current step" gets set as the current
step. As a result we skip steps.

This message was sent by Atlassian JIRA

View raw message