ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonenko Alexander (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-14574) multiple clicks on "Next" button causes skipping of steps while installing a cluster
Date Mon, 18 Jan 2016 16:28:39 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105485#comment-15105485
] 

Antonenko Alexander commented on AMBARI-14574:
----------------------------------------------

[~patelket@us.ibm.com] Hi, as I see you created property "nextBtnClickInProgress", but this
property seems like nothing more than a duplicate of transitionInProgress prop, they do the
same stuff, so if you wanna prevent multiple clicks of submit button, than just use transitionInProgress
in more places, in places that you wanna cover.

p.s. Also there was another patch with better, more elegant fix, that solved this issue. See
AMBARI-12737. I think it stopped working due to some minor changes. Maybe fixing them will
make AMBARI-12737 patch work. 

> multiple clicks on "Next" button causes skipping of steps while installing a cluster
> ------------------------------------------------------------------------------------
>
>                 Key: AMBARI-14574
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14574
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.1.1
>            Reporter: Keta Patel
>            Assignee: Keta Patel
>         Attachments: AMBARI-14574.patch
>
>
> On installation wizard, multiple clicks on the "Next" button can cause skipping of steps.
The timing of the 2nd click decides if that click will be processed again or not. The following
JIRAs had the same issue:
> AMBARI-7195
> AMBARI-7315
> The fix for the above issues helps to resolve most part of the problem. But if the user
happened to click again at the point when the last callback function has just completed (and
thus, has made the "Next" button clickable again) but the next step has not yet completed
its rendering, then the 2nd click gets processed again. The "current step" was already updated
in the code to point to the next step, from the 1st click. So when this 2nd click calls the
"next" function in the router, the subsequent step of the "current step" gets set as the current
step. As a result we skip steps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message