ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Zang <rz...@hortonworks.com>
Subject Re: Review Request 42893: AMBARI-14822 Combo Search: Create auto suggest for Host attribute filters
Date Fri, 29 Jan 2016 00:06:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42893/#review116843
-----------------------------------------------------------


Ship it!




Ship It!

- Richard Zang


On Jan. 28, 2016, 2:43 a.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42893/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 2:43 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: ambari-14822
>     https://issues.apache.org/jira/browse/ambari-14822
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create and show suggestion after user type in the value.
> Hostname (will be a filter substring match)
> IP Address (will be a filter substring match)
> Rack (will be a fixed list of choices, since this is a finite list for a given cluster)
> Versions (will be a fixed list of choices, since this is a finite list of choices for
a given cluster)
> Version Status (will be a fixed list of choices, since this is fixed list)
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/host/combo_search_box.js 3832611 
>   ambari-web/app/utils/ajax/ajax.js c4a1611 
>   ambari-web/app/views/main/host/combo_search_box.js 36af44d 
>   ambari-web/vendor/scripts/visualsearch.js 044977c 
> 
> Diff: https://reviews.apache.org/r/42893/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 23116 tests complete (22 seconds)
> 166 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message