ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Levas <rle...@hortonworks.com>
Subject Re: Review Request 42913: Upgrading ambari-server from 2.0.1 to 2.2.0 sets incorrect value for 'storm.zookeeper.superACL'
Date Thu, 28 Jan 2016 16:12:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42913/#review116781
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java (line
104)
<https://reviews.apache.org/r/42913/#comment177872>

    Doesn't this already happen in UpgradeCatalog210? Why perform this here?


- Robert Levas


On Jan. 28, 2016, 11:02 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42913/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 11:02 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Robert Levas.
> 
> 
> Bugs: AMBARI-14831
>     https://issues.apache.org/jira/browse/AMBARI-14831
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The problem turns out to be that ambari-server upgrade from 2.0.1 to 2.2.0 sets the value
of config as (code):
> storm.zookeeper.superACL: "sasl:{{storm_base_jaas_principal}}",
> However STORM scripts expect the config value to be storm_bare_jaas_principal (code).
Because of this, the value comes out as empty. (screenshot attached)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
7940e02 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
bcbbf41 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
f33a31d 
> 
> Diff: https://reviews.apache.org/r/42913/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message