ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nate Cole <nc...@hortonworks.com>
Subject Re: Review Request 42824: Move Version Definition to its own endpoint
Date Wed, 27 Jan 2016 14:39:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42824/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 9:39 a.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Changes
-------

Updated for comments


Bugs: AMBARI-14804
    https://issues.apache.org/jira/browse/AMBARI-14804


Repository: ambari


Description
-------

For creating repositories from a Version Definition file, create a new endpoint.  This is
because unlike repo management, the stack is not known in advance.

There are some validations missing from this code, but need to give the UI folks a "good"
API to start with.

Still just a couple of reviewers until stabilization.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
070a505 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
61fbd8a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
92b14b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 9d6af76

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java c37abb5

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
e2e455b 
  ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java 450fd95

  ambari-server/src/main/resources/version_definition.xsd 654ea08 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
12d2091 

Diff: https://reviews.apache.org/r/42824/diff/


Testing
-------

Manual.  Automated:

Tests run: 3759, Failures: 0, Errors: 0, Skipped: 31

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:58.624s
[INFO] Finished at: Tue Jan 26 16:11:54 EST 2016
[INFO] Final Memory: 34M/1397M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message