ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Hurley <jhur...@hortonworks.com>
Subject Re: Review Request 42824: Move Version Definition to its own endpoint
Date Wed, 27 Jan 2016 02:39:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42824/#review116521
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java
(line 41)
<https://reviews.apache.org/r/42824/#comment177531>

    GETs shouldn't need a `String body`



ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java
(line 50)
<https://reviews.apache.org/r/42824/#comment177532>

    GETs shouldn't need a `String body`



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
(line 247)
<https://reviews.apache.org/r/42824/#comment177534>

    Heap concerns here?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
(line 268)
<https://reviews.apache.org/r/42824/#comment177535>

    Should this logic be encapsulated in the entity so that it's consistently set?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
(line 277)
<https://reviews.apache.org/r/42824/#comment177536>

    Doc.



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
(lines 72 - 73)
<https://reviews.apache.org/r/42824/#comment177537>

    This implies that there will never be a repo created from an XML without an XSD. We good
with that?


- Jonathan Hurley


On Jan. 26, 2016, 4:37 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42824/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 4:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14804
>     https://issues.apache.org/jira/browse/AMBARI-14804
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For creating repositories from a Version Definition file, create a new endpoint.  This
is because unlike repo management, the stack is not known in advance.
> 
> There are some validations missing from this code, but need to give the UI folks a "good"
API to start with.
> 
> Still just a couple of reviewers until stabilization.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
c7c5d61 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
cce3764 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
92b14b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e367afe

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
c37abb5 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
e2e455b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
450fd95 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
12d2091 
> 
> Diff: https://reviews.apache.org/r/42824/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> Tests run: 3759, Failures: 0, Errors: 0, Skipped: 31
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:58.624s
> [INFO] Finished at: Tue Jan 26 16:11:54 EST 2016
> [INFO] Final Memory: 34M/1397M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message