ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmytro Sen <d...@hortonworks.com>
Subject Re: Review Request 42802: Metric Monitor crashes with NoSuchProcess exception
Date Tue, 26 Jan 2016 15:42:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42802/
-----------------------------------------------------------

(Updated Янв. 26, 2016, 3:42 п.п.)


Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid Wagle.


Bugs: branch-2.2 and trunk
    https://issues.apache.org/jira/browse/branch-2.2
    https://issues.apache.org/jira/browse/trunk


Repository: ambari


Description (updated)
-------

2016-01-25 23:18:18,102 [INFO] emitter.py:91 - server: http://host1:6188/ws/v1/timeline/metrics
Exception in thread Thread-2201:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 1082, in run
    self.function(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/resource_monitoring/core/metric_collector.py", line
45, in process_event
    self.process_host_collection_event(event)
  File "/usr/lib/python2.6/site-packages/resource_monitoring/core/metric_collector.py", line
78, in process_host_collection_event
    metrics.update(self.host_info.get_process_info())
  File "/usr/lib/python2.6/site-packages/resource_monitoring/core/host_info.py", line 93,
in get_process_info
    if STATUS_RUNNING == proc.status():
  File "/usr/lib/python2.6/site-packages/resource_monitoring/psutil/build/lib.linux-x86_64-2.7/psutil/__init__.py",
line 555, in status
    return self._proc.status()
  File "/usr/lib/python2.6/site-packages/resource_monitoring/psutil/build/lib.linux-x86_64-2.7/psutil/_pslinux.py",
line 704, in wrapper
    raise NoSuchProcess(self.pid, self._name)
NoSuchProcess: process no longer exists (pid=3428)

2016-01-25 23:19:18,123 [INFO] emitter.py:91 - server: http://host1:6188/ws/v1/timeline/metrics


A process has been stopped between processes list collection and calling proc.status() for
the already stopped process. Added try-catch block in the patch.


Diffs
-----

  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py d5a8c36


Diff: https://reviews.apache.org/r/42802/diff/


Testing
-------

----------------------------------------------------------------------
Total run:11
Total errors:0
Total failures:0
OK

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.187s
[INFO] Finished at: Tue Jan 26 17:27:29 EET 2016
[INFO] Final Memory: 14M/198M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message