ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmytro Sen <d...@hortonworks.com>
Subject Re: Review Request 42706: Alerts: HDFS alerts based on AMS metrics
Date Tue, 26 Jan 2016 12:49:33 GMT


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/alerts/alert_metrics_deviation.py,
line 69
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219149#file1219149line69>
> >
> >     Should this be a property in ams-site? Do we expect it could change?

No, we don't expect it could change.


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json, line
537
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219150#file1219150line537>
> >
> >     standby (sp) and NameNode (caps)

Fixed


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json, line
540
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219150#file1219150line540>
> >
> >     standby (sp) and NameNode (caps)

Fixed


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json, line
565
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219150#file1219150line565>
> >
> >     revise: The standard deviation threshold above which a warning is produced.

Fixed


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json, line
573
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219150#file1219150line573>
> >
> >     revise: The standard deviation threshold above which a critical alert is produced.

Fixed


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json, line
585
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219150#file1219150line585>
> >
> >     slight revision: within _a given_ time interval.

Fixed


> On Янв. 26, 2016, 1:36 д.п., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json, line
595
> > <https://reviews.apache.org/r/42706/diff/1/?file=1219150#file1219150line595>
> >
> >     standby (sp) and NameNode (caps)

Fixed


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42706/#review116247
-----------------------------------------------------------


On Янв. 25, 2016, 5:28 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42706/
> -----------------------------------------------------------
> 
> (Updated Янв. 25, 2016, 5:28 п.п.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implement script alert based on AMS metrics standard deviation
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/alerts/alert_metrics_deviation.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1eda00f

> 
> Diff: https://reviews.apache.org/r/42706/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message