ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmytro Sen <d...@hortonworks.com>
Subject Re: Review Request 42706: Alerts: HDFS alerts based on AMS metrics
Date Tue, 26 Jan 2016 11:38:12 GMT


> On Янв. 25, 2016, 5:23 п.п., Sid Wagle wrote:
> > Looks good, could also add Jonathan Hurely to reviewers, please?
> > It seems the ams alert is still quite close to HDFS vs being generic, what are your
thoughts about instoducing inheritance here? Can we add the generic implementation to the
resource_managemenent library ?
> 
> Dmytro Sen wrote:
>     I can remove HDFS related code and make the alert generic. Actually +1 from me for
 making it generic. This required to have ability to run the alter only on active namenode,
if it's not the case - we can get rid of all the HDFS related code here.
>     
>     This alert can be implemented no as a script as well.
> 
> Sid Wagle wrote:
>     IMO v1 can be to move this to HDFS in the stack and then create refactor Jira for
2.4.0
>     We should move AMS part into Java code and create a new type so the customization
should only handle service specific points.
>     This would also mean providing stad library functions for caluclating std deviation,
so the HDFS alert only handle active/standby NN and then the parameters, all AMS specific
configs can be handled efficiently in the backend Java code, right?

Agree. AMS backend is a better place to do the math


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42706/#review116118
-----------------------------------------------------------


On Янв. 25, 2016, 5:28 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42706/
> -----------------------------------------------------------
> 
> (Updated Янв. 25, 2016, 5:28 п.п.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implement script alert based on AMS metrics standard deviation
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/alerts/alert_metrics_deviation.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1eda00f

> 
> Diff: https://reviews.apache.org/r/42706/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message