ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Hurley <jhur...@hortonworks.com>
Subject Re: Review Request 42706: Alerts: HDFS alerts based on AMS metrics
Date Tue, 26 Jan 2016 01:36:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42706/#review116247
-----------------------------------------------------------


Fix it, then Ship it!




Mostly user-facing string changes. There are a lot of repetitive ones, so I'll just let you
apply them on all of the alerts.


ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/alerts/alert_metrics_deviation.py
(line 69)
<https://reviews.apache.org/r/42706/#comment177261>

    Should this be a property in ams-site? Do we expect it could change?



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 537)
<https://reviews.apache.org/r/42706/#comment177252>

    standby (sp) and NameNode (caps)



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 540)
<https://reviews.apache.org/r/42706/#comment177253>

    standby (sp) and NameNode (caps)



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 565)
<https://reviews.apache.org/r/42706/#comment177255>

    revise: The standard deviation threshold above which a warning is produced.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 573)
<https://reviews.apache.org/r/42706/#comment177256>

    revise: The standard deviation threshold above which a critical alert is produced.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 585)
<https://reviews.apache.org/r/42706/#comment177257>

    slight revision: within _a given_ time interval.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 595)
<https://reviews.apache.org/r/42706/#comment177258>

    standby (sp) and NameNode (caps)



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json (line 598)
<https://reviews.apache.org/r/42706/#comment177259>

    standby (sp) and NameNode (caps)


- Jonathan Hurley


On Jan. 25, 2016, 12:28 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42706/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 12:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implement script alert based on AMS metrics standard deviation
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/alerts/alert_metrics_deviation.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 1eda00f

> 
> Diff: https://reviews.apache.org/r/42706/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message