ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Levas <rle...@hortonworks.com>
Subject Re: Review Request 42625: Add RBAC for AdminSettings API
Date Mon, 25 Jan 2016 23:11:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42625/#review116212
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 1114)
<https://reviews.apache.org/r/42625/#comment177215>

    For consistency, the descriptive text should read "Manage administrative settings".


- Robert Levas


On Jan. 25, 2016, 5:41 p.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42625/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 5:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, Robert Levas,
Nahappan Somasundaram, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14728
>     https://issues.apache.org/jira/browse/AMBARI-14728
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add RBAC for AdminSettings API
> Only Admin user should have the ability to Create/Update/Delete settings
> All users can Read settings
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
6d74f97e3d96121fd8dc34e356ff85fc4fb65d72 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9fc0a16bee90742abd980ad403eadd724fd10e5d

>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 775eef27a11e3d1f15ab28caa4232580dfe6a9a7

>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ea9e85fd90053e980ce3b711b37fed9ad0103c6d

>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb4958384d2ad262e793de5766d3e37f6600514f

>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 149c9cf403392e6b8867f653922381158827874a

>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 7d885684e4c2d5eedd68dc05a21c56295622dd70

>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 4374fc65a77c7784a1595f6cd60fcfe3f087415b

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AdminSettingServiceTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProviderTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42625/diff/
> 
> 
> Testing
> -------
> 
> Test manually and Unit testing
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message