ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajit Kumar" <ajit.ku...@hortonworks.com>
Subject Re: Review Request 42339: Provide CRUD support for admin-settings
Date Thu, 21 Jan 2016 22:52:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42339/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 10:52 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, Nahappan Somasundaram,
Sumit Mohanty, and Sid Wagle.


Changes
-------

Changes as per comments


Bugs: AMBARI-14750
    https://issues.apache.org/jira/browse/AMBARI-14750


Repository: ambari


Description
-------

Provide CRUD support for admin-settings


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
c7c5d61b70ea38f22861519783733e9b9ebd415d 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AdminSettingService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
3801cc3da56769b2dfc5ca1ceb22a8aa95eab63f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e367afe4e319a8de441d201d619da4f20b48dcdb

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AdminSettingDAO.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AdminSettingEntity.java
PRE-CREATION 
  ambari-server/src/main/resources/META-INF/persistence.xml 3979bc0782840284678d5e2d6f5af797d011aa18

  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AdminSettingResourceProviderTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AdminSettingDAOTest.java PRE-CREATION

  ambari-server/src/test/java/org/apache/ambari/server/orm/entities/AdminSettingEntityTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/42339/diff/


Testing
-------

Tested API through curl
unit tests

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [9.890s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.060s]
[INFO] Ambari Web ........................................ SUCCESS [2:15.144s]
[INFO] Ambari Views ...................................... SUCCESS [3.885s]
[INFO] Ambari Admin View ................................. SUCCESS [11.634s]
[INFO] ambari-metrics .................................... SUCCESS [0.388s]
[INFO] Ambari Metrics Common ............................. SUCCESS [2.729s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [5.239s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.931s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [4.818s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.567s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [1:00.778s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [3.318s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [59.382s]
[INFO] Ambari Server ..................................... SUCCESS [1:03:30.478s]
[INFO] Ambari Functional Tests ........................... SUCCESS [1:57.459s]
[INFO] Ambari Agent ...................................... SUCCESS [13.973s]
[INFO] Ambari Client ..................................... SUCCESS [0.041s]
[INFO] Ambari Python Client .............................. SUCCESS [2.306s]
[INFO] Ambari Groovy Client .............................. SUCCESS [12.051s]
[INFO] Ambari Shell ...................................... SUCCESS [0.033s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.863s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [9.254s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:11:12.017s
[INFO] Finished at: Wed Jan 20 16:02:44 PST 2016
[INFO] Final Memory: 223M/1079M
[INFO] ------------------------------------------------------------------------


Thanks,

Ajit Kumar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message